Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mention of OpenFermion-FQE to the frontpage #740

Merged
merged 5 commits into from
Aug 10, 2021

Conversation

babbush
Copy link
Contributor

@babbush babbush commented Aug 7, 2021

I noticed that we aren't advertising OpenFermion-FQE here. But we should be right? Feel free to edit aspects of the description.

@babbush babbush requested a review from ncrubin August 7, 2021 17:10
@google-cla google-cla bot added the cla: yes label Aug 7, 2021
README.rst Outdated
a high performance emulator of fermionic quantum evolutions specified
by a sequence of fermion operators, which can exploit fermionic
symmetries such as spin and particle number. It is built as a
plugin because C++ backends for OpenFermion-FQE must be compiled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave off the C++ part. 1) fqe will fall back on already faster than cirq python librarires 2) it is built on top of C-extensions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in that case is there a good reason why we don't merge into OpenFermion core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any event, I removed mention of that. I also decided to delete the link to the projects page since I don't feel like we've kept up with it at all and at this point it is not even close to a representative sample of the many projects using OpenFermion. What do you think?

Copy link
Collaborator

@ncrubin ncrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babbush babbush merged commit f685ffc into quantumlib:master Aug 10, 2021
ncrubin pushed a commit to ncrubin/OpenFermion that referenced this pull request Jul 25, 2022
* Adding mention of OpenFermion-FQE to the frontpage

* updated spacing

* fixed grammar

* adding downloads badge too

* removed projects page link (not up to date), removed mention of C++ bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants