Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use io in setup so it doesn't depend on future #298

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Use io in setup so it doesn't depend on future #298

merged 1 commit into from
Mar 29, 2018

Conversation

kevinsung
Copy link
Collaborator

No description provided.

jarrodmcc
jarrodmcc approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@jarrodmcc jarrodmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way that coveralls report is right. We need this change so I'm approving, then testing locally on a clean install

@jarrodmcc
Copy link
Contributor

Seems to work locally on my clean install apart from a small anomalous glitch with scandir that I fixed, so I'll merge this

@jarrodmcc jarrodmcc merged commit cb08df7 into quantumlib:master Mar 29, 2018
@kevinsung kevinsung deleted the io branch March 29, 2018 20:30
philipp-q pushed a commit to philipp-q/OpenFermion that referenced this pull request Sep 2, 2020
@kevinsung @jarrodmcc
Use io to fix dependency in setup.py (quantumlib#298)
230a75b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmcc jarrodmcc jarrodmcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinsung @jarrodmcc