update files to conform to new mypy standard #6662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
requested review from
mrwojtek,
vtomole,
cduck,
a team,
wcourtney and
verult
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6662 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1066 1066
Lines 91832 91833 +1
==========================================
Hits 89826 89826
- Misses 2006 2007 +1 ☔ View full report in Codecov by Sentry. |
senecameeks
reviewed
Jul 10, 2024
| @@ -899,6 +899,8 @@ def test_cphase_unitary(angle_rads, expected_unitary): | |||
| np.testing.assert_allclose(cirq.unitary(cirq.cphase(angle_rads)), expected_unitary) | |||
|
|
|||
|
|
|||
| # TODO(#6663): fix this use case. | |||
| @pytest.mark.xfail | |||
There was a problem hiding this comment.
Do you know why this stopped working? If just the latter assertion is broken can we break it out into it's own test and mark it as failed / track a fix for it, WDYT?
There was a problem hiding this comment.
looks like either comparison between sympy numbers and floats changed or something changed that changes the functions called during comparison ... either way I opened #6663 to fix it.
dstrain115
approved these changes
Jul 10, 2024
dev_tools/conf/mypy.ini
Outdated
| @@ -1,5 +1,5 @@ | |||
| [mypy] | |||
| exclude = dev_tools/modules_test_data/.*/setup\.py | |||
| exclude = dev_tools/modules_test_data/.*/setup\.py|cirq-rigetti/(?!__init__.)*\.py # Temperarly exclude cirq-rigetti (see #6661) | |||
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
this changes updates code to conform to the new mypy standard. Note that cirq-rigetti needs a lot of work so I temporarily turned off mypy checks for it and filed quantumlib#6661 to track that work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changes updates code to conform to the new mypy standard.
Note that cirq-rigetti needs a lot of work so I temporarily turned off mypy checks for it and filed #6661 to track that work.