Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve repr of _BaseAncillaQid classes with prefix #6555

Merged

Conversation

pavoljuhas
Copy link
Collaborator

Quote the prefix string in repr of _BaseAncillaQid classes.

Follow up to #6554.

@pavoljuhas pavoljuhas force-pushed the fix-clean-qubit-repr-with-prefix branch from 921a801 to 08bc2ee Compare April 9, 2024 21:47
@pavoljuhas pavoljuhas marked this pull request as ready for review April 9, 2024 21:47
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners April 9, 2024 21:47
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (9ab6601) to head (921a801).
Report is 2 commits behind head on main.

❗ Current head 921a801 differs from pull request most recent head 08bc2ee. Consider uploading reports for the commit 08bc2ee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6555   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files        1124     1124           
  Lines       95468    95486   +18     
=======================================
+ Hits        93359    93377   +18     
  Misses       2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanujkhattar tanujkhattar enabled auto-merge (squash) April 9, 2024 22:10
@tanujkhattar tanujkhattar merged commit 1bec6b5 into quantumlib:main Apr 9, 2024
29 checks passed
@pavoljuhas pavoljuhas deleted the fix-clean-qubit-repr-with-prefix branch April 9, 2024 22:36
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
* Add failing repr tests for CleanQubit and BorrowableQubit with prefix

* Quote prefix string in repr of `_BaseAncillaQid` classes
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
* Add failing repr tests for CleanQubit and BorrowableQubit with prefix

* Quote prefix string in repr of `_BaseAncillaQid` classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants