Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-daily workflow failures on Mac OS X #6532

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Mar 27, 2024

Install development version of cirq, but with stable dependencies.
Avoid using the pip-install --pre option because it installs
pre-release of every direct and transitive dependency.

Example failure: https://github.com/quantumlib/Cirq/actions/runs/8444592307/job/23130415923
Pass with this change: https://github.com/quantumlib/Cirq/actions/runs/8460206027/job/23179852811

Related to #6336

Install development version of cirq, but with stable dependencies.
Avoid using the pip-install `--pre` options because it applies
to every direct and transitive package installed.
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (46e4483) to head (71e3ea8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6532   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files        1105     1105           
  Lines       95154    95154           
=======================================
  Hits        93045    93045           
  Misses       2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas marked this pull request as ready for review March 28, 2024 02:16
@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners March 28, 2024 02:16
@pavoljuhas pavoljuhas requested a review from dabacon March 28, 2024 02:16
@pavoljuhas pavoljuhas enabled auto-merge (squash) March 28, 2024 02:17
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas merged commit e5ad426 into quantumlib:main Mar 28, 2024
31 checks passed
@vtomole
Copy link
Collaborator

vtomole commented Mar 28, 2024

@pavoljuhas Fastest merge in the west 😄

@pavoljuhas pavoljuhas deleted the fix-ci-daily branch March 28, 2024 18:23
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
Install development version of cirq, but with stable dependencies.
Avoid using the pip-install `--pre` option because it installs
pre-release of every direct and transitive dependency.

Example failure: https://github.com/quantumlib/Cirq/actions/runs/8444592307/job/23130415923
Pass with this change: https://github.com/quantumlib/Cirq/actions/runs/8460206027/job/23179852811

Related to quantumlib#6336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants