-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update start notebook to use get_engine
instead of get_qcs_objects_for_notebook
#6483
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6483 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1105 1105
Lines 94936 94963 +27
=======================================
+ Hits 92810 92837 +27
Misses 2126 2126 ☔ View full report in Codecov by Sentry. |
this might not work if it's run from outside corp network in which case authentication is needed which is part of
to check if it will from outside corp network try to run then notebook in colab.research |
Thanks @NoureldinYosri for the catch! #6485 exposes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Addresses #6427 by removing the incorrect
processor_id
in the notebook.Although this doesn't fix the underlying issue as to why
get_qcs_objects_for_notebook
is incorrect and doesn't address Will's second point in his commentFYI, I verified this works as a good replacement for
get_qcs_objects_for_notebook