Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ClassicalSimulator to use simulation infrastructure #6432

Merged
merged 106 commits into from
Mar 19, 2024
Merged

Update ClassicalSimulator to use simulation infrastructure #6432

merged 106 commits into from
Mar 19, 2024

Conversation

shef4
Copy link
Contributor

@shef4 shef4 commented Jan 30, 2024 •
edited
Loading

Related issue - #6343

TypeError: ClassicalStateSimulator.__init__() missing 3 required positional arguments: 'initial_state', 'qubits', and 'classical_data'

shef4 and others added 30 commits September 28, 2023 11:54
@shef4
Merge pull request #1 from quantumlib/master
0a68ee5 
updat with latest version
@shef4
router mishandling mid-circuit measurements
9698377 
Fixes quantumlib#6293
@shef4
updated editable install instr to add all packages
f68471d
@shef4
Merge pull request #2 from quantumlib/master
8c5816e 
Allow specifying settings field from Cirq-ionq (quantumlib#5817)
@shef4
removed debug prints
3a5828f
@shef4
Merge pull request #4 from shef4/developer-enviroment-guideline-update
4e4eb61 
Developer enviroment guideline update
@shef4
Merge pull request #6 from quantumlib/master
cf32124 
updating forked repo
@shef4
add code to Break intermediate measurements
44707af 
on 3+ qubits into single qubit measurements
if -and only if- the result isn't stored (i.e. key is None)
and test for changes in RoutCQC
@shef4
removing intended changes
9f0bf30
@shef4
updated sytanx and functionailty
337aea8
@shef4
Update development.md
601757b 
removed unintended change
@shef4
clean up routing transformer notebook
3c28f45
@shef4
reset transformer notebook to same as main
7d4be5a 
updates from review- varible names, ciruit build
@shef4
added ignore type to key variable
01b0fea
@shef4
Clearified error, comment and test information
33b89f9
@shef4
clarified test function names
93591b2
@shef4
Merge branch 'master' into #6293_routcqc_stage_2
9902705
@shef4
reduced line length for comment and error msg
d5e8338
@shef4
updated error message
78386f2
@shef4
removed trailing white space
671c5b4
@shef4
Merge branch 'master' into #6293_routcqc_stage_2
1f1eaad
@shef4
Merge pull request #8 from shef4/#6293_routcqc_stage_2
8b7ef8e 
updating master
@shef4
started drafts of class refactor and Todos
b41c643
@shef4
completed class infa and started test updates
a5920a3
@shef4
removed test changes for now
e676b0f
@shef4
testing code changes
e156b72
@shef4
saving current changes before sync
553cd5c
@shef4
Merge branch 'main' into refactor_classical_simulator_with_custom_sim…
e8d9bdf 
…ulator_infa
@shef4
cleaned up code and restored original test file
36da4fe
@shef4
CI bug fixes
392540c
@shef4
Copy link
Contributor Author

shef4 commented Feb 24, 2024

Hi @NoureldinYosri, I'm not sure what is causing this CI fail, any insight would be really appreciated.

FAILED dev_tools/docker_test.py::test_docker_pre - assert 1 == 0
 +  where 1 = CompletedProcess(args=['docker run cirq_image_pre python -c "import cirq; assert cirq.__version__ is not None"'], returncode=1).returncode
= 1 failed, 20135 passed, 146 skipped, 86 xfailed, 726 warnings in 365.34s (0:06:05) =

@NoureldinYosri
Copy link
Collaborator

NoureldinYosri commented Feb 26, 2024 •
edited
Loading

@shef4 I temporarily supressed that test because it is failing at head.

@shef4
Copy link
Contributor Author

shef4 commented Feb 26, 2024

@NoureldinYosri Thanks, glad to know it's working. Learnt some interesting concepts from this issue!

NoureldinYosri
NoureldinYosri requested changes Mar 13, 2024
View reviewed changes
cirq-core/cirq/sim/classical_simulator.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/classical_simulator.py Show resolved Hide resolved
@NoureldinYosri NoureldinYosri merged commit a2425eb into quantumlib:main Mar 19, 2024
31 checks passed
@NoureldinYosri NoureldinYosri mentioned this pull request Mar 19, 2024
Closed
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
@shef4 @jselig-rigetti
Update ClassicalSimulator to confirm to simulation abstraction (quant…
0b93e27 
…umlib#6432)
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@shef4
Update ClassicalSimulator to confirm to simulation abstraction (quant…
78ae7fc 
…umlib#6432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoureldinYosri NoureldinYosri NoureldinYosri approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees

@NoureldinYosri NoureldinYosri

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shef4 @NoureldinYosri @CirqBot