Remove mypy --next #5763
Merged
Remove mypy --next #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavoljuhas
reviewed
Jul 14, 2022
dev_tools/conf/mypy.ini
Outdated
| [mypy-apiclient.*,freezegun.*,matplotlib.*,mpl_toolkits,multiprocessing.dummy,oauth2client.*,pandas.*,proto.*,pytest.*,scipy.*,sortedcontainers.*,setuptools.*,pylatex.*,networkx.*,qiskit.*,pypandoc.*,ply.*,_pytest.*,google.api.*,google.api_core.*,grpc.*,google.auth.*,google.oauth2.*,google.protobuf.text_format.*,quimb.*,pyquil.*,google.cloud.*,filelock.*,codeowners.*,tqdm.*,importlib_metadata.*,google.colab.*,IPython.*,astroid.*,pylint.*] | ||
|
|
||
| [mypy-google.api_core.*,,google.auth.*,google.colab.*,google.protobuf.text_format.*,google.protobuf.*,google.cloud.*] |
There was a problem hiding this comment.
- Please replace
,,-->, google.protobuf.*should be perhaps removed, it has its own block at line 25
pavoljuhas
reviewed
Jul 14, 2022
Comment on lines
22
to
27
| # Treat symbols imported from Google's protobuf library as type Any. | ||
| # This supresses errors due to attributes not known to typeshed, | ||
| # This suppresses errors due to attributes not known to typeshed, | ||
| # e.g. Descriptor._options. | ||
| [mypy-google.protobuf.*] | ||
| follow_imports = skip | ||
| follow_imports_for_stubs = true |
There was a problem hiding this comment.
Perhaps we can move this under the first Google block?
There was a problem hiding this comment.
it has a slightly different structure for the flags it is changing
pavoljuhas
approved these changes
Jul 14, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit cleaner separation in the giant list of packages.
Fixes #3767