Remove deprecated class SerializableDevice #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavoljuhas
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
|
Can someone better versed with the proto-to-GridDevice process please check the |
dabacon
reviewed
Jul 12, 2022
| @@ -14,7 +14,6 @@ | |||
| 'SYC_GATESET', | |||
| 'Sycamore', | |||
| 'Sycamore23', | |||
| 'SerializableDevice', | |||
There was a problem hiding this comment.
lol good thing a SerializableDevice was never json serialized.
dabacon
reviewed
Jul 12, 2022
I fail to see the one in known_devices_test.py, perhaps we look at different versions? Cleaning up the reference in quantum_runtime.py as below causes some test failures so I'd rather leave it for a separate PR. diff --git a/cirq-google/cirq_google/workflow/quantum_runtime.py b/cirq-google/cirq_google/workflow/quantum_runtime.py
index 56fa0a33..644f6b94 100644
--- a/cirq-google/cirq_google/workflow/quantum_runtime.py
+++ b/cirq-google/cirq_google/workflow/quantum_runtime.py
@@ -59,10 +59,7 @@ class SharedRuntimeInfo:
return 'cirq.google'
def _json_dict_(self) -> Dict[str, Any]:
- d = dataclass_json_dict(self)
- # TODO (gh-4699): serialize `device` as well once SerializableDevice is serializable.
- del d['device']
- return d
+ return dataclass_json_dict(self)
def __repr__(self) -> str:
return _compat.dataclass_repr(self, namespace='cirq_google') |
Do not refer to Serializable Devices.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Oh damn github search index is .... not fast. |
dabacon
approved these changes
Jul 12, 2022
Device validates Circuit, not other way around.
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Remove deprecated property GridDevice.qubits. Clean up documentation references to the SerializableDevice and update the circuit validation example in the specification.md doc. Part of quantumlib#5050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated property GridDevice.qubits.
Clean up documentation references to the SerializableDevice and
update the circuit validation example in the specification.md doc.
Part of #5050