Re-enable doctest #5742
Merged
Re-enable doctest #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
requested review from
ColemanCollins,
nakardo,
gmauricio,
a team,
vtomole,
cduck,
wcourtney and
verult
as code owners
pavoljuhas
reviewed
Jul 12, 2022
dev_tools/docs/run_doctest.py
Outdated
Comment on lines
228
to
233
| excluded = [ | ||
| 'cirq-google/cirq_google/engine/client/', | ||
| 'cirq-google/cirq_google/cloud/', | ||
| 'cirq-google/cirq_google/api', | ||
| ] | ||
| file_names = [f for f in file_names if not any(f.startswith(x) for x in excluded)] |
There was a problem hiding this comment.
This avoids hard failure in cirq-google/cirq_google/optimizers/optimize_for_sycamore_test.py.
I guess we can skip doctesting docstrings in tests.
Suggested change
| excluded = [ | |
| 'cirq-google/cirq_google/engine/client/', | |
| 'cirq-google/cirq_google/cloud/', | |
| 'cirq-google/cirq_google/api', | |
| ] | |
| file_names = [f for f in file_names if not any(f.startswith(x) for x in excluded)] | |
| excluded = [ | |
| 'cirq-google/cirq_google/engine/client/', | |
| 'cirq-google/cirq_google/cloud/', | |
| 'cirq-google/cirq_google/api/', | |
| ] | |
| file_names = [f for f in file_names if not any(f.startswith(x) for x in excluded)] | |
| file_names = [f for f in file_names if not f.endswith('_test.py')] |
There was a problem hiding this comment.
Oh yeah good, idea skipping tests. Added skipping.
pavoljuhas
reviewed
Jul 12, 2022
dev_tools/docs/run_doctest.py
Outdated
| @@ -161,6 +174,7 @@ def exec_tests( | |||
| failed, attempted = 0, 0 | |||
| error_messages = [] | |||
| for test in tests: | |||
| print(test.file_name) | |||
There was a problem hiding this comment.
Please check if the printout should be in.
There was a problem hiding this comment.
definitely a left over print debug. removed
pavoljuhas
approved these changes
Jul 12, 2022
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
pavoljuhas
reviewed
Jul 13, 2022
dev_tools/docs/run_doctest.py
Outdated
| @@ -230,17 +229,19 @@ def main(): | |||
| 'cirq-google/cirq_google/cloud/', | |||
| 'cirq-google/cirq_google/api', | |||
There was a problem hiding this comment.
To be on a safe side - let's replace api --> api/ as for above paths.
pavoljuhas
added
the
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this PR out for review.
There is a broken test due to a pending deprecation.
Fixes #5678