Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate common serializers #5611

Conversation

verult
Copy link
Collaborator

@verult verult commented Jun 24, 2022

These common serializers are most likely not used by users (except one edge use case @dstrain115 knows about), but for completeness, they are deprecated in this PR since they are exposed publicly.

@dstrain115

@verult verult requested a review from dstrain115 June 24, 2022 22:02
@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners June 24, 2022 22:02
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 24, 2022
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 27, 2022
@CirqBot CirqBot merged commit ea4ef65 into quantumlib:master Jun 27, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 27, 2022
@verult verult mentioned this pull request Jul 7, 2022
40 tasks
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
These common serializers are most likely not used by users (except one edge use case @dstrain115 knows about), but for completeness, they are deprecated in this PR since they are exposed publicly.

@dstrain115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants