Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat default gate families with tags_to_ignore or tags_to_accept as custom gate families in Gatesets #5553

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Treat default gate families with tags_to_ignore or tags_to_accept as custom gate families in Gatesets #5553

merged 4 commits into from
Jun 21, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #5543

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners June 17, 2022 22:34
@tanujkhattar tanujkhattar requested a review from pavoljuhas June 17, 2022 22:34
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jun 17, 2022
pavoljuhas
pavoljuhas requested changes Jun 18, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should test the behavior of tags_to_ignore/tags_to_accept separately.

verult
verult reviewed Jun 18, 2022
View reviewed changes
Copy link
Collaborator

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

If you don't mind, could you also help me uncomment this test case in this PR? Let me know if that ends up breaking tests.

Cirq/cirq-google/cirq_google/devices/known_devices_test.py

Lines 509 to 512 in 70487fd

# Broken due to issue #5543.
# TODO(#5543) Uncomment
# cirq.Z,
# cirq.Z(q0).with_tags(cirq_google.PhysicalZTag()),

@tanujkhattar tanujkhattar requested a review from wcourtney as a code owner June 21, 2022 01:25
@tanujkhattar tanujkhattar requested a review from pavoljuhas June 21, 2022 01:29
@tanujkhattar
Copy link
Collaborator Author

@verult @pavoljuhas I've addressed all comments, this is ready for a re-review.

verult
verult approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

pavoljuhas
pavoljuhas approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tanujkhattar tanujkhattar merged commit 5c8d11e into quantumlib:master Jun 21, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Treat default gate families with tags_to_ignore or tags_to_accept as …
1ede6af 
…custom gate families in Gatesets (quantumlib#5553)

* Treat default gate families with tags_to_ignore or tags_to_accept as custom gate families

* Add more tests and uncomment known_devices_test

* Replace equals with is
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Treat default gate families with tags_to_ignore or tags_to_accept as …
08f7fa0 
…custom gate families in Gatesets (quantumlib#5553)

* Treat default gate families with tags_to_ignore or tags_to_accept as custom gate families

* Add more tests and uncomment known_devices_test

* Replace equals with is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@verult verult verult approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@wcourtney wcourtney Awaiting requested review from wcourtney

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateset: fails to accept an operation if the gate type matches multiple GateFamilies in the gateset.
4 participants
@tanujkhattar @verult @pavoljuhas @CirqBot