Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text_diagram_exponent() type #555

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Fix text_diagram_exponent() type #555

merged 1 commit into from
Jul 2, 2018

Conversation

cduck
Copy link
Collaborator

@cduck cduck commented Jul 2, 2018

Change the return type to what most of the code assumes it is: Union[float, value.Symbol]

@cduck cduck requested a review from Strilanc July 2, 2018 23:40
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 2, 2018
@cduck
Copy link
Collaborator Author

cduck commented Jul 2, 2018

Related to #554.

Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduck cduck merged commit 90756cc into quantumlib:master Jul 2, 2018
@cduck cduck deleted the exp_type branch July 19, 2018 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants