Parameter sweeps polish #5515
Parameter sweeps polish #5515
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
docs/params.ipynb
Outdated
| @@ -102,10 +102,10 @@ | |||
| "source": [ | |||
| "q0 = cirq.LineQubit(0)\n", | |||
| "\n", | |||
| "circuit1 = cirq.Circuit([cirq.H(q0), cirq.Z(q0)**0.5, cirq.H(q0), cirq.measure(q0)])\n", | |||
| "circuit1 = cirq.Circuit([cirq.H(q0), cirq.Z(q0) ** 0.5, cirq.H(q0), cirq.measure(q0)])\n", | |||
There was a problem hiding this comment.
Which formatter did you run? We format the main cirq code with black 22.1 which does not include spaces around ** (see #5157).
There was a problem hiding this comment.
I used black and black[jupyter]. Running black --version results in black, 22.3.0 (compiled: yes). Should I downgrade?
There was a problem hiding this comment.
Shouldn't need to downgrade because that's the version we use currently; I was mistaken about it being 22.1 (see https://github.com/quantumlib/Cirq/blob/master/dev_tools/requirements/deps/format.txt). I'm a bit surprised that black[jupyter] seems to be treating notepad code differently, but I don't have too much experience with that. It would be nice to integrate notebook formatting into the check/format-incremental script and our CI checks so that notebook code formatting is handled automatically.
There was a problem hiding this comment.
OK to leave it as-is for now then?
There was a problem hiding this comment.
Well, I guess I'd prefer to revert the padding around ** to be consistent with cirq code, but up to you.
Co-authored-by: Matthew Neeley <[email protected]>
Phrasing changes, ran black formatter, cleared outputs in Simulation
Phrasing changes, ran black formatter, cleared outputs in Simulation
Some phrasing changes. Ran a formatter. Cleared outputs in Simulation