Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message when invalid sympy arg is serialized #5487

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

verult
Copy link
Collaborator

@verult verult commented Jun 11, 2022

Fixes #2384

Clarifies what sympy expressions are allowed when a user tries to serialize a circuit which contains unrecognized Sympy expressions.

@dstrain115

@verult verult requested a review from dstrain115 June 11, 2022 00:11
@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners June 11, 2022 00:11
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 11, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 13, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 13, 2022
@CirqBot CirqBot merged commit 75794cb into quantumlib:master Jun 13, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 13, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…#5487)

Fixes quantumlib#2384

Clarifies what sympy expressions are allowed when a user tries to serialize a circuit which contains unrecognized Sympy expressions.

@dstrain115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need documentation on what protobuf serializations are allowed
4 participants