Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IonQTargetGateset and use it for circuit compilations. #5479

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #5129 #4901 #4153
Replaces #5127

  • Adds support for compiling > 2q operations to ionq's target gateset
  • Does not do the "merge 2q operations to a connected component" optimization, to preserve existing behavior. We can add another preprocess_transformer if we want to do the optimization.
  • Deprecates cirq_ionq.decompose_to_device in favour of using cirq.optimize_for_target_gateset(circuit, gateset=cirq_ionq.IonQTargetGateset) for compiling circuits.

cc @Cynocracy @dabacon

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 10, 2022
@Cynocracy
Copy link
Contributor

Cynocracy commented Jun 10, 2022

Thanks for picking this up! LGTM, but I don't think I can approve for some reason

Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, but LGTM

cirq-ionq/cirq_ionq/ionq_gateset.py Show resolved Hide resolved
cirq-ionq/cirq_ionq/ionq_gateset.py Outdated Show resolved Hide resolved
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 13, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 13, 2022
@CirqBot CirqBot merged commit 3360198 into master Jun 13, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 13, 2022
@CirqBot CirqBot deleted the ionq_target_gateset branch June 13, 2022 12:10
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 13, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…b#5479)

Fixes quantumlib#5129 quantumlib#4901 quantumlib#4153
Replaces quantumlib#5127

* Adds support for compiling > 2q operations to ionq's target gateset
* Does not do the "merge 2q operations to a connected component" optimization, to preserve existing behavior. We can add another `preprocess_transformer` if we want to do the optimization. 
* Deprecates `cirq_ionq.decompose_to_device`  in favour of using `cirq.optimize_for_target_gateset(circuit, gateset=cirq_ionq.IonQTargetGateset)` for compiling circuits. 

cc @Cynocracy @dabacon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IONQ] Vendor Transformer adoption
4 participants