Test round trip of gate to operation to gate #5354
Conversation
| for gate_cls in gate_subclasses: | ||
| if gate_cls in exceptions: | ||
| continue |
There was a problem hiding this comment.
Just loop over gate_subclass less exceptions for clarity sake ?
| try: | ||
| gates = cirq.read_json(filename) | ||
| except FileNotFoundError: | ||
| if gate_cls in skip_classes: | ||
| skipped.add(gate_cls) | ||
| continue |
There was a problem hiding this comment.
Can we do an existance check with file.exists instead of a try catch ?
| if not isinstance(gates, collections.abc.Iterable): | ||
| gates = [gates] |
There was a problem hiding this comment.
Is this needed because some json files have lists of things instead of one single thing in them ?
There was a problem hiding this comment.
yep...classic python, object or list of objects :(
| def all_subclasses(cls): | ||
| return set(cls.__subclasses__()).union( | ||
| [s for c in cls.__subclasses__() for s in all_subclasses(c)] | ||
| ) |
There was a problem hiding this comment.
This isn't at risk for infinite recursion right ? (if we had two gates with circular dependencies of some kind)
There was a problem hiding this comment.
I think this is fine since the type hierarchy has to be a dag.
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests'] |
CirqBot
removed
automerge
We decided that we would do this in lieu of making everything a gate operation #2626
Note that currently PauliStringPhasorGate fails this #5167
This also uncovers some missing gates that should be json serializable, opened #5353 for this.
Also notice that two of the issues in this comment are of the for #XYXY and isn't that amazing.