Add support for decompositions of parameterized cirq.DiagonalGate
#5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
daxfohl
reviewed
Mar 17, 2022
| @@ -144,7 +144,7 @@ def _value_equality_values_(self) -> Any: | |||
| return tuple(self._diag_angles_radians) | |||
|
|
|||
| def _decompose_for_basis( | |||
| self, index: int, bit_flip: int, theta: float, qubits: Sequence['cirq.Qid'] | |||
| self, index: int, bit_flip: int, theta: value.TParamVal, qubits: Sequence['cirq.Qid'] | |||
There was a problem hiding this comment.
Should be 'cirq.TParamVal' if you ever get back to this. xref #4383
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…uantumlib#5085) - Adds support for decomposing parameterized `cirq.DiagonalGate`. - Global phase is ignored for parameterized version because `cirq.GlobalPhaseGate` doesn't yet support symbols. - Part of quantumlib#4858
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…uantumlib#5085) - Adds support for decomposing parameterized `cirq.DiagonalGate`. - Global phase is ignored for parameterized version because `cirq.GlobalPhaseGate` doesn't yet support symbols. - Part of quantumlib#4858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cirq.DiagonalGate.cirq.GlobalPhaseGatedoesn't yet support symbols.