Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default decomposition for cirq.TwoQubitDiagonalGate #5084

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Add default decomposition for cirq.TwoQubitDiagonalGate #5084

merged 5 commits into from
Mar 16, 2022

Conversation

tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar commented Mar 16, 2022 •
edited
Loading

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners March 16, 2022 20:52
@tanujkhattar tanujkhattar requested a review from viathor March 16, 2022 20:52
@CirqBot CirqBot added the size: S 10< lines changed <50 label Mar 16, 2022
@tanujkhattar tanujkhattar added the priority/high This is something that should get done soon, e.g. within a month. label Mar 16, 2022
95-martin-orion
95-martin-orion approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed tests! Having an explicit demonstration of equality between the new decomposition and the existing unitary saves me the effort of trying to reproduce your linear algebra :)

@tanujkhattar tanujkhattar merged commit 2fb5651 into quantumlib:master Mar 16, 2022
@tanujkhattar tanujkhattar deleted the two_qubit_diagonal_gate branch March 16, 2022 22:20
@tanujkhattar tanujkhattar changed the title Add default decomposition for cirq.TwoQubitDiagonalGate Add default decomposition for cirq.TwoQubitDiagonalGate Mar 17, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Add default decomposition for cirq.TwoQubitDiagonalGate (quantumlib#5084
0cee02b 
)

* Add default decomposition for cirq.TwoQubitDiagonalGate

* Update pyquil tests
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Add default decomposition for cirq.TwoQubitDiagonalGate (quantumlib#5084
7e2b804 
)

* Add default decomposition for cirq.TwoQubitDiagonalGate

* Update pyquil tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton left review comments

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

@95-martin-orion 95-martin-orion

Labels
priority/high This is something that should get done soon, e.g. within a month. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanujkhattar @MichaelBroughton @95-martin-orion @CirqBot