Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google-specific variant for noise properties. #5082
Add Google-specific variant for noise properties. #5082
Changes from all commits
93b0496
e1f37fa
fc1ba46
e18677a
57b86e6
1e92b1c
4a4d283
3caecbc
b49101f
f02c04f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does these sets indicate what gates are supported or which ones will have noise put on them ? I'm a little confused here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the supported gates - see #4964, where validation will raise an error if metrics are provided for gates outside these sets. The division between sets is also used to determine which types of error to apply for each gate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call it a FsimDeviceNoiseProperties ? In theory we might eventually want one for CZ at some point ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is strictly necessary - the inclusion of FSim in the supported gates doesn't prevent someone from using this to construct noise for a CZ device (in which case no FSim noise will be added).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange to have a copy of the same documentation in two locations. Is this standard practice? Perhaps you should instead reference the docstring in
devices.SuperconductingQubitsNoiseProperties
, and only discuss the difference between this class and its parent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most cases it's OK to omit parent-class documentation, but I wanted to include it here since both this and the parent are
@dataclass
es. As a result, the source of the "inherited args" is somewhat opaque - documenting them here can save the reader the work of inspecting the parent class.