Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public fields from fsim #5075

Merged
merged 4 commits into from
Mar 13, 2022
Merged

Remove public fields from fsim #5075

merged 4 commits into from
Mar 13, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Mar 13, 2022 •
edited
Loading

Change public fields to private, and encapsulate with getters and deprecated setters.

Closes #4851

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners March 13, 2022 20:26
@daxfohl daxfohl requested a review from mpharrigan March 13, 2022 20:27
@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 13, 2022
@daxfohl daxfohl mentioned this pull request Mar 13, 2022
Closed
13 tasks
MichaelBroughton
MichaelBroughton approved these changes Mar 13, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might want to fix mismatched type hints between __init__ and the properties we added as well. I'll leave you to merge once fixed.

cirq-core/cirq/ops/fsim_gate.py Outdated Show resolved Hide resolved
@MichaelBroughton MichaelBroughton self-assigned this Mar 13, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 13, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 13, 2022
@CirqBot CirqBot merged commit bfc04b8 into quantumlib:master Mar 13, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 13, 2022
@daxfohl daxfohl deleted the privatevarsfsim branch March 13, 2022 21:46
This was referenced Mar 14, 2022
Closed
Closed
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Remove public fields from fsim (quantumlib#5075)
05c2db2 
Change public fields to private, and encapsulate with getters and deprecated setters.

Closes quantumlib#4851
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
Remove public fields from fsim (quantumlib#5075)
2dadcb3 
Change public fields to private, and encapsulate with getters and deprecated setters.

Closes quantumlib#4851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove public fields from gates
3 participants
@daxfohl @MichaelBroughton @CirqBot