Order of keys shouldn't matter when comparing cirq.google.KeyValueExecutableSpec #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybruguier
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
mpharrigan
reviewed
Mar 14, 2022
|
Thanks, @mpharrigan and PTAL when you have the time? It's not urgent on my side. |
|
Can you add a section to the docstring about the new equality semantics of KeyValueSpec since we're overwriting the auto-generated dataclass equality method? And add a test for the new equality semantics that constructs the kvspec using tuples and the ordinary constructor? |
|
Like so? |
mpharrigan
approved these changes
Mar 14, 2022
|
I think this could be ready to merge. But happy to work more on it if there are further comments, of course. |
mpharrigan
added
area/workflow
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)'] |
CirqBot
removed
automerge
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
tonybruguier
added a commit
to tonybruguier/Cirq
that referenced
this pull request
Apr 14, 2022
…cutableSpec (quantumlib#5073) For issue quantumlib#4734. It was discussed there that the order of the keys should not matter.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…cutableSpec (quantumlib#5073) For issue quantumlib#4734. It was discussed there that the order of the keys should not matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #4734. It was discussed there that the order of the keys should not matter.