Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust runtime estimator for high numbers of qubits #5049

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Adjust runtime estimator for high numbers of qubits #5049

merged 2 commits into from
Mar 4, 2022

Conversation

dstrain115
Copy link
Collaborator

  • Cap number of qubits at 55.
  • Noticed one of the formulas gives a negative value when testing
    on the built-in Bristlecone device. Oops.
  • This was not noticed since all the testing was done on 54 qubit
    Sycamore chips.

@dstrain115
Adjust runtime estimator for high numbers of qubits
68170fc 
- Cap number of qubits at 55.
- Noticed one of the formulas gives a negative value when testing
on the built-in Bristlecone device.  Oops.
- This was not noticed since all the testing was done on 54 qubit
Sycamore chips.
@dstrain115 dstrain115 requested review from wcourtney, a team, vtomole, cduck and verult as code owners March 2, 2022 20:32
@dstrain115 dstrain115 requested a review from mpharrigan March 2, 2022 20:32
@CirqBot CirqBot added the size: S 10< lines changed <50 label Mar 2, 2022
MichaelBroughton
MichaelBroughton approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be good to bake in a few more failsafes here in the future.

@MichaelBroughton MichaelBroughton self-assigned this Mar 3, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 3, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 3, 2022
@CirqBot CirqBot merged commit 557cdec into quantumlib:master Mar 4, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 4, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Adjust runtime estimator for high numbers of qubits (quantumlib#5049)
33d8ede 
- Cap number of qubits at 55.
- Noticed one of the formulas gives a negative value when testing
on the built-in Bristlecone device.  Oops.
- This was not noticed since all the testing was done on 54 qubit
Sycamore chips.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@verult verult Awaiting requested review from verult

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstrain115 @MichaelBroughton @CirqBot