Update getting started notebook #5046
Conversation
maffoo
commented
Mar 1, 2022
maffoo
commented
- Use Circuit.transform_qubits instead of cg.optimize_for_sycamore, since all we need to do is change qubits.
- Don't specify a gate_set, which will use CircuitSerializer by default.
- Use standard string representation of cirq.Result.
- Remove unused imports.
- Use Circuit.transform_qubits instead of cg.optimize_for_sycamore. - Don't specify a gate_set, which will use CircuitSerializer by default. - Use standard string representation of cirq.Result. - Remove unused imports.
maffoo
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
lgtm. Will leave approval to someone more familiar with transformers |
| "# Transform circuit to use an available hardware qubit.\n", | ||
| "hw_circuit = circuit.transform_qubits(lambda q: valid_qubit)\n", |
There was a problem hiding this comment.
While I agree with not using optimize_for_gateset since it breaks WYSIWYG, I worry that removing gateset considerations entirely from this tutorial will leave readers stranded as soon as they attempt something outside the HW gateset.
CC @tanujkhattar to recommend a WYSIWYG-friendly transformer for this, if one exists.
There was a problem hiding this comment.
Instead of using a transformer, we could point them to further documentation for non-native gates. Either here or in the "Next steps" section at the end.
There was a problem hiding this comment.
We currently have a next step "Explore best practices for getting circuits to run on hardware." That seems like it would be a natural places to talk about transformers that can compiler to native gates. It currently talks about validation and optimized_for_sycamore, so this would need to be updated to reflect recent development.
There was a problem hiding this comment.
+1 to Matthew's recommendation - if we update that doc to cover this detail (here or in a follow-up), I'd be happy to sign off on the changes here.
There was a problem hiding this comment.
I updated the test to talk about transform_qubits instead of optimized_for_sycamore and added a note about transforming to available gates with a link to the best practices guide. I couldn't see any guides about transformers or compilation target gatesets, but once we have something we can link to that instead.
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
- Use Circuit.transform_qubits instead of cg.optimize_for_sycamore, since all we need to do is change qubits. - Don't specify a gate_set, which will use CircuitSerializer by default. - Use standard string representation of cirq.Result. - Remove unused imports.
