Refactors convert_to_sycamore_gates to abstract out analytical decomposition methods in cirq_google.two_qubit_to_sycamore
#5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
approved these changes
Mar 3, 2022
cirq-google/cirq_google/transformers/analytical_decompositions/two_qubit_to_sycamore.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/transformers/analytical_decompositions/two_qubit_to_sycamore.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/transformers/analytical_decompositions/two_qubit_to_sycamore.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/transformers/analytical_decompositions/two_qubit_to_sycamore.py
Show resolved
Hide resolved
Comment on lines
+110
to
+113
| 1. Adjacent `cirq.SWAP` and `cirq.ZPowGate` wrapped in a circuit operation of length 2. | ||
| 2. `cirq.PhasedISwapPowGate` with exponent = 1 or phase_exponent = 0.25. | ||
| 3. `cirq.SWAP`, `cirq.ISWAP`. | ||
| 4. `cirq.CNotPowGate`, `cirq.CZPowGate`, `cirq.ZZPowGate`. |
There was a problem hiding this comment.
Might want to mention how many SYCs each of these produces.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…mposition methods in `cirq_google.two_qubit_to_sycamore` (quantumlib#5044) * Add cirq_google.two_qubit_to_sycamore containing analytical decomposition methods * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cirq_google.optimizers.convert_to_sycamore_gatesto abstract out analytical decomposition methods in a separate modulecirq_google.transformers.analytical_decompositions.two_qubit_to_sycamore_gates.cirq_google.ConvertToSycamoreGatesto the new transformer infrastructure, as part of Migration of optimizers in vendor packages to new transformers infrastructure. #5028