Add repeat-until functionality to subcircuits #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested changes
Feb 25, 2022
There was a problem hiding this comment.
Very cool. I think I'd like @mpharrigan's input on this as a potential user of this feature (e.g. would this work for measurement-based QC?), but overall I'm quite happy with how well Conditions work here.
daxfohl
commented
Feb 25, 2022
|
Should we say this closes #461? |
It's good to mention this on that issue, but I don't think it fully closes it. There are simulator-based optimizations for explicit post-selection (e.g. forcing measurements to a specific result) that this doesn't support. |
|
Also tagging #3234 |
95-martin-orion
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Opted to merge #5033 first since it's smaller - this will need conflict resolution after that finishes.
|
@95-martin-orion no conflicts |
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
* Allow flattening of subcircuits * format * Add serialization logic and tests * Change flatten_repetitions (default False) to use_repetition_ids (default True) * Add shape tests for simulation results from flattened subcircuits * docs * add repeat_until * repr/json/etc * format * chagne do_while to repeat_until * merge fix * make mapped_single_loop private * Address code review comments. * Fix test * simplify branch * simplify branch * simplify branch * add unbound controls in repeat_until to control_keys
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Allow flattening of subcircuits * format * Add serialization logic and tests * Change flatten_repetitions (default False) to use_repetition_ids (default True) * Add shape tests for simulation results from flattened subcircuits * docs * add repeat_until * repr/json/etc * format * chagne do_while to repeat_until * merge fix * make mapped_single_loop private * Address code review comments. * Fix test * simplify branch * simplify branch * simplify branch * add unbound controls in repeat_until to control_keys
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Allow flattening of subcircuits * format * Add serialization logic and tests * Change flatten_repetitions (default False) to use_repetition_ids (default True) * Add shape tests for simulation results from flattened subcircuits * docs * add repeat_until * repr/json/etc * format * chagne do_while to repeat_until * merge fix * make mapped_single_loop private * Address code review comments. * Fix test * simplify branch * simplify branch * simplify branch * add unbound controls in repeat_until to control_keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds repeat-until functionality to subcircuits. It's only valid on subcircuits that do not use repetition ids, as otherwise there wouldn't be any mutating measurement value to repeat until.
@95-martin-orion no urgency here, and if we want a different approach for this I'm fine with closing it.