-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cg.workflow] Update str(ProcessorRecord) #5012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be good for e.g. plot legends
mpharrigan
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
February 22, 2022 23:25
vtomole
reviewed
Feb 22, 2022
@@ -70,6 +70,9 @@ def get_processor(self) -> 'cg.EngineProcessor': | |||
def __repr__(self): | |||
return dataclass_repr(self, namespace='cirq_google') | |||
|
|||
def __str__(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Suggested change
def __str__(self): | |
def __str__(self) -> str: |
MichaelBroughton
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after victory comment.
mpharrigan
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Feb 24, 2022
CirqBot
added
the
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
label
Feb 24, 2022
CirqBot
removed
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
labels
Feb 24, 2022
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
These should be good for e.g. plot legends
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
These should be good for e.g. plot legends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be good for e.g. plot legends