Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make circuit._prev_moment_available a public method. #4980

Merged
merged 8 commits into from
Feb 14, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #4976

@tanujkhattar tanujkhattar requested review from a team and vtomole as code owners February 10, 2022 23:38
@tanujkhattar tanujkhattar requested a review from cduck as a code owner February 10, 2022 23:38
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 10, 2022
@daxfohl
Copy link
Contributor

daxfohl commented Feb 11, 2022

Consider bikeshedding the name if we make it public. Every time I stumble into this method I think it's a boolean. The arg name is a bit odd too.

cirq-core/cirq/circuits/circuit.py Outdated Show resolved Hide resolved
cirq-core/cirq/circuits/circuit.py Outdated Show resolved Hide resolved
cirq-core/cirq/circuits/circuit.py Show resolved Hide resolved
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 14, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 14, 2022
@CirqBot CirqBot merged commit 87d3632 into quantumlib:master Feb 14, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 14, 2022
95-martin-orion pushed a commit to 95-martin-orion/Cirq that referenced this pull request Mar 2, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we make circuit._prev_moment_available given impact of CCOs ?
4 participants