-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transformer primitive to merge connected component of operations in a circuit op #4974
Merged
tanujkhattar
merged 7 commits into
quantumlib:master
from
tanujkhattar:merge_to_circuit_ops_primitive
Feb 11, 2022
Merged
Add transformer primitive to merge connected component of operations in a circuit op #4974
tanujkhattar
merged 7 commits into
quantumlib:master
from
tanujkhattar:merge_to_circuit_ops_primitive
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synced offline, LGTM. Let's clarify moment preserving behaviors for this function in docstring then we're good to merge.
…e_to_circuit_ops_primitive
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
…in a circuit op (quantumlib#4974) * Add transformer primitive to merge connected component of operations in a circuit op * Add merge_k_qubit_unitaries_to_circuit_op primitive * Add measurement gate to tests * Add and improve docstrings
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…in a circuit op (quantumlib#4974) * Add transformer primitive to merge connected component of operations in a circuit op * Add merge_k_qubit_unitaries_to_circuit_op primitive * Add measurement gate to tests * Add and improve docstrings
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…in a circuit op (quantumlib#4974) * Add transformer primitive to merge connected component of operations in a circuit op * Add merge_k_qubit_unitaries_to_circuit_op primitive * Add measurement gate to tests * Add and improve docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new primitives to greedily build connected components of merge-able operations and wrap each connected component in a new tagged circuit operation, which can then be operated upon by a later transformer.
Specifically, adds:
cirq.merge_operations_to_circuit_op
&cirq.merge_k_qubit_unitaries_to_circuit_op
Part of #3237
Important step towards fixing issues mentioned in #4494
Will be used to rewrite existing merge* optimizers as part of #4722