Deprecate device.qubit_set in cirq_google. #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
requested review from
cduck,
verult,
vtomole,
wcourtney and
a team
as code owners
95-martin-orion
approved these changes
Feb 7, 2022
|
so wait, the only way to get a device's qubits now is to go through a level of indirection? |
|
Yes, this was discussed in the design review for devices p2 and we signed off on moving |
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
Yet more of quantumlib#4744 . It also looks like now we can get rid of the device shim @mpharrigan , @dstrain115 (will leave to seperate PR).
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Yet more of quantumlib#4744 . It also looks like now we can get rid of the device shim @mpharrigan , @dstrain115 (will leave to seperate PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet more of #4744 .
It also looks like now we can get rid of the device shim @mpharrigan , @dstrain115 (will leave to seperate PR).