Deprecate device.decompose_operation in cirq_ionq. #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
requested review from
cduck,
ColemanCollins,
dabacon,
gmauricio,
nakardo,
vtomole and
a team
as code owners
dabacon
approved these changes
Feb 2, 2022
cirq-ionq/cirq_ionq/ionq_devices.py
Outdated
| if operation in _VALID_GATES: | ||
| return operation | ||
| assert cirq.has_unitary(operation), ( | ||
| f'Operation {operation} that is not available on the IonQ API nor does it have a ' |
| from cirq import _compat | ||
|
|
||
|
|
||
| _VALID_GATES = cirq.Gateset( |
There was a problem hiding this comment.
adding to the import time I see :)
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
|
The original We should ideally create a new cirq transformer (aka optimizer) for converting circuits to the ionq native gatesets and use that as a recommendation to replace the deprecated This is tracked in #4901 |
|
Right, although I don't think you or I should work on implementing this. Ideally someone from ionq will come along and do this. |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet more of #4744 .