Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop_empty_moments and drop_negligible_operations transformers. #4915

Merged
merged 9 commits into from
Jan 31, 2022

Conversation

tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar requested review from cduck, vtomole, wcourtney and a team as code owners January 28, 2022 23:22
@tanujkhattar tanujkhattar requested a review from maffoo January 28, 2022 23:22
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jan 28, 2022
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, then LGTM.

@tanujkhattar
Copy link
Collaborator Author

@maffoo Thanks for the review! Addressed all comments, merging now.

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 31, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 31, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jan 31, 2022

Automerge cancelled: A required status check is not present.

Missing statuses: ['Coverage check', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 31, 2022
@tanujkhattar tanujkhattar merged commit 86c873b into quantumlib:master Jan 31, 2022
@tanujkhattar tanujkhattar deleted the drop_transformers branch January 31, 2022 23:06
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…s. (quantumlib#4915)

* Add drop_empty_moments and drop_negligible_operations transformers

* Fix notebook tests

* Fix ejectz tests

* Replace DropEmptyMoments with drop_empty_moments.

* Fix isolated_notebook_test

* Address comments.

Co-authored-by: Cirq Bot <[email protected]>
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…s. (quantumlib#4915)

* Add drop_empty_moments and drop_negligible_operations transformers

* Fix notebook tests

* Fix ejectz tests

* Replace DropEmptyMoments with drop_empty_moments.

* Fix isolated_notebook_test

* Address comments.

Co-authored-by: Cirq Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants