-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drop_empty_moments
and drop_negligible_operations
transformers.
#4915
Add drop_empty_moments
and drop_negligible_operations
transformers.
#4915
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, then LGTM.
cirq-core/cirq/optimizers/merge_interactions_to_sqrt_iswap_test.py
Outdated
Show resolved
Hide resolved
@maffoo Thanks for the review! Addressed all comments, merging now. |
Automerge cancelled: A required status check is not present. Missing statuses: ['Coverage check', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
…s. (quantumlib#4915) * Add drop_empty_moments and drop_negligible_operations transformers * Fix notebook tests * Fix ejectz tests * Replace DropEmptyMoments with drop_empty_moments. * Fix isolated_notebook_test * Address comments. Co-authored-by: Cirq Bot <[email protected]>
…s. (quantumlib#4915) * Add drop_empty_moments and drop_negligible_operations transformers * Fix notebook tests * Fix ejectz tests * Replace DropEmptyMoments with drop_empty_moments. * Fix isolated_notebook_test * Address comments. Co-authored-by: Cirq Bot <[email protected]>
DropEmptyMoments
andDropNegligible
optimizers.