Add synchronize_terminal_measurements transformer to replace SynchronizeTerminalMeasurements
#4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tanujkhattar
commented
Jan 28, 2022
•
tanujkhattar
commented
- Part of Organization (and deprecation) of cirq-core/optimizers in cirq-core/transformers #4722
- Follows the new Transformer API Compiling: Circuit Transformers API #4483
- Supports no compile tags NoCompile Tag for optimizers NoCompile Tag for optimizers #4253
- Fixes SynchronizeTerminalMeasurements doesn't handle multi-qubit measurements #4907
…izeTerminalMeasurements
…hronize_terminal
tanujkhattar
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vtomole
reviewed
Jan 28, 2022
cirq-core/cirq/transformers/synchronize_terminal_measurements.py
Outdated
Show resolved
Hide resolved
cirq-core/cirq/transformers/synchronize_terminal_measurements.py
Outdated
Show resolved
Hide resolved
cirq-core/cirq/transformers/synchronize_terminal_measurements.py
Outdated
Show resolved
Hide resolved
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Transformer pass to move terminal measurements to the end of circuit.""" |
There was a problem hiding this comment.
Is this defined as the last moment in the circuit ?
There was a problem hiding this comment.
Yes, but the precise moment to which it get's added depends upon the value of after_other_operations flag.
|
@MichaelBroughton Added tests for |
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…ronizeTerminalMeasurements` (quantumlib#4911) - Part of quantumlib#4722 - Follows the new Transformer API quantumlib#4483 - Supports no compile tags NoCompile Tag for optimizers quantumlib#4253 - Fixes quantumlib#4907
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…ronizeTerminalMeasurements` (quantumlib#4911) - Part of quantumlib#4722 - Follows the new Transformer API quantumlib#4483 - Supports no compile tags NoCompile Tag for optimizers quantumlib#4253 - Fixes quantumlib#4907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.