Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase atol for sub_state_vector() #4877

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Increase atol for sub_state_vector() #4877

merged 6 commits into from
Jan 26, 2022

Conversation

tonybruguier
Copy link
Contributor

Attempts to fix #4786

@CirqBot CirqBot added the Size: XS <10 lines changed label Jan 23, 2022
@tonybruguier tonybruguier marked this pull request as ready for review January 24, 2022 17:03
@tonybruguier tonybruguier requested review from cduck, vtomole and a team as code owners January 24, 2022 17:03
@tonybruguier tonybruguier requested a review from dabacon January 24, 2022 17:03
@MichaelBroughton MichaelBroughton self-assigned this Jan 25, 2022
MichaelBroughton
MichaelBroughton requested changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test here to catch what this is fixing ? maybe the one from the linked issue ?

@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 26, 2022
@tonybruguier
Copy link
Contributor Author

Good point. It would catch changes in the stimulator's and thus a need to change the default tolerance. Added. Thank you. PTAL.

MichaelBroughton
MichaelBroughton approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 26, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 26, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jan 26, 2022

Automerge cancelled: A required status check is not present.

Missing statuses: ['Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 26, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 26, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 26, 2022
@CirqBot CirqBot merged commit 64e2eac into quantumlib:master Jan 26, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 26, 2022
@tonybruguier tonybruguier deleted the cirq_tol branch January 26, 2022 13:47
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tonybruguier @rht
Increase atol for sub_state_vector() (quantumlib#4877)
8708b9a 
Attempts to fix quantumlib#4786
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tonybruguier
Increase atol for sub_state_vector() (quantumlib#4877)
2cb5e58 
Attempts to fix quantumlib#4786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dabacon dabacon Awaiting requested review from dabacon dabacon was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default atol for sub_state_vector is too picky for default precision of simulator
3 participants
@tonybruguier @CirqBot @MichaelBroughton