Use a Protocol for TRANSFORMER to ensure common arg names #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up some of the internals of the transformer decorator and simplifies the types. Follow-up to #4797
tanujkhattar
requested changes
Jan 22, 2022
tanujkhattar
approved these changes
Jan 24, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…#4871) * Use a Protocol for TRANSFORMER to ensure common arg names Also cleans up some of the internals of the transformer decorator and simplifies the types. Follow-up to quantumlib#4797 * Fix Protocol import for 3.7 * Fixes from review * Add type annotations in transformer implementation Co-authored-by: Tanuj Khattar <[email protected]>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…#4871) * Use a Protocol for TRANSFORMER to ensure common arg names Also cleans up some of the internals of the transformer decorator and simplifies the types. Follow-up to quantumlib#4797 * Fix Protocol import for 3.7 * Fixes from review * Add type annotations in transformer implementation Co-authored-by: Tanuj Khattar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up some of the internals of the transformer decorator by inlining the implementations and simplifies the types.
Follow-up to #4797