Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata property to device. #4868

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of #4743 . Note that if in the process of deprecating other things for #4744 , I will pull vendor devices onto using metadata to keep behavior working.

@MichaelBroughton MichaelBroughton requested review from cduck, vtomole and a team as code owners January 21, 2022 05:46
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 21, 2022
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 21, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 21, 2022
@CirqBot CirqBot merged commit 394b9cf into quantumlib:master Jan 21, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 21, 2022
MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of quantumlib#4743 . Note that if in the process of deprecating other things for quantumlib#4744 , I will pull vendor devices onto using metadata to keep behavior working.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of quantumlib#4743 . Note that if in the process of deprecating other things for quantumlib#4744 , I will pull vendor devices onto using metadata to keep behavior working.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of quantumlib#4743 . Note that if in the process of deprecating other things for quantumlib#4744 , I will pull vendor devices onto using metadata to keep behavior working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants