Deprecate XmonDevice, Foxtail and Bristlecone. #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
requested review from
cduck,
mrwojtek,
vtomole,
wcourtney and
a team
as code owners
tanujkhattar
requested changes
Jan 20, 2022
| @@ -150,3 +151,13 @@ | |||
| from cirq_google.json_resolver_cache import _class_resolver_dictionary | |||
|
|
|||
| _register_resolver(_class_resolver_dictionary) | |||
|
|
|||
| __spec_copy__ = sys.modules[__name__].__spec__ | |||
There was a problem hiding this comment.
Why do we need to explicitly copy the spec and then pass it to deprecate_attributes ? Can't we just do:
sys.modules[__name__] = _compat.deprecate_attributes(
sys.modules[__name__],
{
'Bristlecone': ('v0.15', 'Bristlecone will no longer be supported.'),
'Foxtail': ('v0.15', 'Foxtail will no longer be supported.'),
},
)There was a problem hiding this comment.
for some reason this update clobbers the spec entry in sys.modules I'm not a python wizard, but this worked well enough. So it is needed.
| @@ -43,7 +43,8 @@ def qubits(self): | |||
| raise NotImplementedError() | |||
|
|
|||
|
|
|||
| def test_init(): | |||
| @mock.patch.dict(os.environ, clear='CIRQ_TESTING') | |||
There was a problem hiding this comment.
You can just add a ALLOW_DEPRECATION_IN_TEST = 'ALLOW_DEPRECATION_IN_TEST' at the beginning of the file instead of adding a patch to each individual test
There was a problem hiding this comment.
Try as I might I couldn't get this for some reason or other, so I just left as mocks.
tanujkhattar
approved these changes
Jan 21, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
MichaelBroughton
added a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
* Deprecate XmonDevice, Foxtail and Bristlecone. * Tanuj feedback. Co-authored-by: Cirq Bot <[email protected]>
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Deprecate XmonDevice, Foxtail and Bristlecone. * Tanuj feedback. Co-authored-by: Cirq Bot <[email protected]>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Deprecate XmonDevice, Foxtail and Bristlecone. * Tanuj feedback. Co-authored-by: Cirq Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4856 .
qcs_notebook fxn now returns a Sycamore device which feels like "more correct" behavior.
BREAKING_CHANGE=Json and repr files were removed for these objects since it looks like they were never really needed.
The Foxtail and Bristlecone objects were just static singleton datastores we had in the library itself - in their current form there would never be any need to serialize them. Plus working in the deserialization of global singletons to avoid some warnings isn't something that seemed worth doing for this removal.
xref #4744