Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred measurements transformer #4849

Merged
merged 56 commits into from
Feb 9, 2022
Merged

Deferred measurements transformer #4849

merged 56 commits into from
Feb 9, 2022

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Jan 17, 2022

Closes #4818, Also reimplements mux simulation based on this, in preparation to deprecate ignore_measurement_results.

Needs a follow-up after #4512 to support classical controls on multi-qubit measurements, as we need some way of defining the condition "at least one qubit is not zero" to match the classical interpretation of a multi-qubit measurement.

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jan 17, 2022
@daxfohl daxfohl marked this pull request as ready for review January 20, 2022 01:52
@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners January 20, 2022 01:52
@daxfohl daxfohl requested a review from tanujkhattar January 20, 2022 01:52
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

Will approve after cirq-sync discussion on ignoring classical noise on measurement gates

Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've verified that this works as expected (had some doubts earlier, apologies for the confusion).

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 9, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 9, 2022
@CirqBot CirqBot merged commit 0bdc9f1 into quantumlib:master Feb 9, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 9, 2022
@daxfohl daxfohl deleted the defer branch February 10, 2022 08:00
95-martin-orion pushed a commit to 95-martin-orion/Cirq that referenced this pull request Mar 2, 2022
Closes quantumlib#4818, Also reimplements `mux` simulation based on this, in preparation to deprecate `ignore_measurement_results`.

Needs a follow-up after quantumlib#4512 to support classical controls on multi-qubit measurements, as we need some way of defining the condition "at least one qubit is not zero" to match the classical interpretation of a multi-qubit measurement.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Closes quantumlib#4818, Also reimplements `mux` simulation based on this, in preparation to deprecate `ignore_measurement_results`.

Needs a follow-up after quantumlib#4512 to support classical controls on multi-qubit measurements, as we need some way of defining the condition "at least one qubit is not zero" to match the classical interpretation of a multi-qubit measurement.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Closes quantumlib#4818, Also reimplements `mux` simulation based on this, in preparation to deprecate `ignore_measurement_results`.

Needs a follow-up after quantumlib#4512 to support classical controls on multi-qubit measurements, as we need some way of defining the condition "at least one qubit is not zero" to match the classical interpretation of a multi-qubit measurement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferred Measurement Transformer
5 participants