Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to dev environment page in CONTRIBUTING.md #4843

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

verult
Copy link
Collaborator

@verult verult commented Jan 14, 2022

Might be helpful to add a section in CONTRIBUTING.md to describe dev environment setup as it could be one of the first docs contributors look at. WDYT?

edit: Just found links to development.md elsewhere in the doc. Do you think it makes sense to have a dedicated section, to make it obvious where to look for dev environment setup?

@verult verult requested review from cduck, vtomole and a team as code owners January 14, 2022 22:48
@verult verult requested a review from dstrain115 January 14, 2022 22:48
@CirqBot CirqBot added the Size: XS <10 lines changed label Jan 14, 2022
@MichaelBroughton MichaelBroughton self-assigned this Jan 15, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a few redundant links . I actually had this same problem a little while ago.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 16, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 16, 2022
@CirqBot CirqBot merged commit 4cfa845 into quantumlib:master Jan 16, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 16, 2022
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
Might be helpful to add a section in CONTRIBUTING.md to describe dev environment setup as it could be one of the first docs contributors look at. WDYT?

edit: Just found links to development.md elsewhere in the doc. Do you think it makes sense to have a dedicated section, to make it obvious where to look for dev environment setup?
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Might be helpful to add a section in CONTRIBUTING.md to describe dev environment setup as it could be one of the first docs contributors look at. WDYT?

edit: Just found links to development.md elsewhere in the doc. Do you think it makes sense to have a dedicated section, to make it obvious where to look for dev environment setup?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants