-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GridDeviceMetadata. #4839
Add GridDeviceMetadata. #4839
Conversation
cirq-core/cirq/protocols/json_test_data/GridDeviceMetadata.repr
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the absolute nittiest of nits: griddevice_metadata.py
should be grid_device_metadata.py
, in keeping with standard camel -> snake case conversion and the fact that GridDevice
is two separate words.
|
||
def __init__( | ||
self, | ||
qubit_pairs: Iterable[Tuple['cirq.Qid', 'cirq.Qid']], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there could be isolated qubits that are not coupled to any other qubit. Imagine a real device where we have broken couplers so can't perform 2-qubit gates with a qubit, but still need to bias it to operate the other qubits on the device. This is definitely an edge case, but something we might want to support.
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
Adds GridDeviceMetadata implementation as part of #4743 .