Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GridDeviceMetadata. #4839

Merged
merged 5 commits into from
Jan 14, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

Adds GridDeviceMetadata implementation as part of #4743 .

@MichaelBroughton MichaelBroughton requested review from cduck, vtomole and a team as code owners January 14, 2022 10:27
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jan 14, 2022
cirq-core/cirq/devices/device.py Outdated Show resolved Hide resolved
cirq-core/cirq/devices/device.py Outdated Show resolved Hide resolved
cirq-core/cirq/devices/device.py Outdated Show resolved Hide resolved
cirq-core/cirq/devices/device.py Outdated Show resolved Hide resolved
cirq-core/cirq/devices/device.py Outdated Show resolved Hide resolved
cirq-core/cirq/devices/device.py Outdated Show resolved Hide resolved
cirq-core/cirq/devices/device_test.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the absolute nittiest of nits: griddevice_metadata.py should be grid_device_metadata.py, in keeping with standard camel -> snake case conversion and the fact that GridDevice is two separate words.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 14, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 14, 2022
@CirqBot CirqBot merged commit ca391ca into quantumlib:master Jan 14, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 14, 2022

def __init__(
self,
qubit_pairs: Iterable[Tuple['cirq.Qid', 'cirq.Qid']],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there could be isolated qubits that are not coupled to any other qubit. Imagine a real device where we have broken couplers so can't perform 2-qubit gates with a qubit, but still need to bias it to operate the other qubits on the device. This is definitely an edge case, but something we might want to support.

MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants