Add DeviceMetaData class. #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
requested review from
cduck,
vtomole and
a team
as code owners
95-martin-orion
requested changes
Jan 13, 2022
cirq-core/cirq/devices/device.py
Outdated
|
|
||
| self._nx_graph = nx_graph | ||
| self._kwargs_names = kwargs.keys() | ||
| self.__dict__.update(kwargs) |
There was a problem hiding this comment.
Directly modifying the object dict feels super hacky to me - this will lead to cases like:
md = DeviceMetaData(qubits, nx_graph, blah=12)
# elsewhere, maybe in a different file
result = md.blah
which is difficult to trace: DeviceMetaData has no blah member variable, and using an instance other than the one initialized above will cause an error.
If we really need to store arbitrary typeless information in this object (as opposed to using subclasses which add explicitly-typed member variables), we should pack it into a Dict[str, Any].
There was a problem hiding this comment.
Removed altogether.
95-martin-orion
approved these changes
Jan 13, 2022
cirq-core/cirq/devices/device.py
Outdated
Comment on lines
202
to
206
| if qubits is not None: | ||
| qubits = frozenset(qubits) | ||
| self._qubits_set: Optional[FrozenSet['cirq.Qid']] = cast( | ||
| Optional[FrozenSet['cirq.Qid']], qubits | ||
| ) |
There was a problem hiding this comment.
Nit: this would be more concise as
self._qubits_set: Optional[FrozenSet['cirq.Qid']] = (
None if qubits is None else frozenset(qubits)
)
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
MichaelBroughton
added a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Adds standalone DeviceMetaData class. First step in quantumlib#4743 .
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Adds standalone DeviceMetaData class. First step in quantumlib#4743 .
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Adds standalone DeviceMetaData class. First step in quantumlib#4743 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds standalone DeviceMetaData class. First step in #4743 .