Fix warning on array creation from ragged sequences #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid conversion of ragged nested sequences to numpy array. Use simple equality check to compare list of tuples. Use RandomState.choice to get item index instead of item itself (which implies conversion to numpy.array).
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Avoid conversion of ragged nested sequences to numpy array. Use simple equality check to compare lists of tuples. Use RandomState.choice to get item index instead of the item itself which implies conversion to numpy.array. Fixes check/pytest -Werror:'Creating an ndarray from ragged'
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Avoid conversion of ragged nested sequences to numpy array. Use simple equality check to compare lists of tuples. Use RandomState.choice to get item index instead of the item itself which implies conversion to numpy.array. Fixes check/pytest -Werror:'Creating an ndarray from ragged'
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Avoid conversion of ragged nested sequences to numpy array. Use simple equality check to compare lists of tuples. Use RandomState.choice to get item index instead of the item itself which implies conversion to numpy.array. Fixes check/pytest -Werror:'Creating an ndarray from ragged'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid conversion of ragged nested sequences to numpy array.
Use simple equality check to compare lists of tuples.
Use RandomState.choice to get item index instead of the item itself
which implies conversion to numpy.array.
Fixes check/pytest -Werror:'Creating an ndarray from ragged'