Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize type annotations in cirq.circuits #4776

Merged
merged 6 commits into from
Dec 23, 2021
Merged

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Dec 21, 2021

Follow-up to the cirq.sim one. Note this reduces things that cause recursive dependencies as well, so watch out for this in code reviews.

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners December 21, 2021 21:38
@daxfohl daxfohl requested a review from dabacon December 21, 2021 21:38
@CirqBot CirqBot added the size: M 50< lines changed <250 label Dec 21, 2021
@vtomole
Copy link
Collaborator

vtomole commented Dec 21, 2021

Tagging: #4383

@daxfohl
Copy link
Contributor Author

daxfohl commented Dec 21, 2021

Also tagging #4657

@daxfohl
Copy link
Contributor Author

daxfohl commented Dec 23, 2021

cc @95-martin-orion

@95-martin-orion 95-martin-orion self-assigned this Dec 23, 2021
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 23, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 23, 2021
@CirqBot CirqBot merged commit 9aede58 into quantumlib:master Dec 23, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 23, 2021
@daxfohl daxfohl deleted the cirqdot2 branch December 23, 2021 21:48
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
Follow-up to the cirq.sim one. Note this reduces things that cause recursive dependencies as well, so watch out for this in code reviews.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Follow-up to the cirq.sim one. Note this reduces things that cause recursive dependencies as well, so watch out for this in code reviews.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Follow-up to the cirq.sim one. Note this reduces things that cause recursive dependencies as well, so watch out for this in code reviews.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants