Fix ignore_measurement_results=True for subcircuits #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
approved these changes
Dec 23, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
Dear, sweet @CirqBot. Your ruthless vigilance towards "incomplete" tests inspires us all 😛 |
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Density matrix simulator has a bug that if `ignore_measurement_results` is set, that setting is overlooked within subcircuits. The reason is that this setting check is done in `SimulatorBase.core_iterator`, but that only iterates the outermost circuit. The fix is to move the check into `ActOnArgs.measure`, to ensure that any measurement is replaced with a dephase operation. Surprisingly we did not even have a test for the non-subcircuit case. This PR adds a test for that and the subcircuit case.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Density matrix simulator has a bug that if `ignore_measurement_results` is set, that setting is overlooked within subcircuits. The reason is that this setting check is done in `SimulatorBase.core_iterator`, but that only iterates the outermost circuit. The fix is to move the check into `ActOnArgs.measure`, to ensure that any measurement is replaced with a dephase operation. Surprisingly we did not even have a test for the non-subcircuit case. This PR adds a test for that and the subcircuit case.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Density matrix simulator has a bug that if `ignore_measurement_results` is set, that setting is overlooked within subcircuits. The reason is that this setting check is done in `SimulatorBase.core_iterator`, but that only iterates the outermost circuit. The fix is to move the check into `ActOnArgs.measure`, to ensure that any measurement is replaced with a dephase operation. Surprisingly we did not even have a test for the non-subcircuit case. This PR adds a test for that and the subcircuit case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Density matrix simulator has a bug that if
ignore_measurement_resultsis set, that setting is overlooked within subcircuits.The reason is that this setting check is done in
SimulatorBase.core_iterator, but that only iterates the outermost circuit.The fix is to move the check into
ActOnArgs.measure, to ensure that any measurement is replaced with a dephase operation.Surprisingly we did not even have a test for the non-subcircuit case. This PR adds a test for that and the subcircuit case.