Add JSON serialization support for QasmUGate #4750
Conversation
| @@ -156,6 +156,7 @@ def _parallel_gate_op(gate, qubits): | |||
| 'VarianceStoppingCriteria': cirq.work.VarianceStoppingCriteria, | |||
| 'VirtualTag': cirq.VirtualTag, | |||
| 'WaitGate': cirq.WaitGate, | |||
| 'QasmUGate': cirq.circuits.qasm_output.QasmUGate, | |||
There was a problem hiding this comment.
Should have alphabetical ordering (before 'QuantumFourierTransformGate': cirq.QuantumFourierTransformGate,. While we are at it, let's fix the ordering of 'RandomGateChannel': cirq.RandomGateChannel, as well.
There was a problem hiding this comment.
It is more than that! Many items are placed in the wrong order. Since you mentioned it, I reordered them in the new commit.
There was a problem hiding this comment.
Nice! Thanks for going the extra mile! I've left a few minor comments then this should be good to merge.
Sorry, I did not see this until I click... |
|
@vtomole You are right, the CLA bot is screwed up. I tried to trigger the CI process like last time, but it did not work. It is interesting that the bot is not complaining about me actually, it complained about you:
Finally, I have to reset hard to the commit before clicking "commit suggestions" and forced push it. It seems that the PR goes back to the right track. 🙏 |
vtomole
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
This PR provides the serialization support for the `QasmUGate` class following [serialization.md](https://github.com/quantumlib/Cirq/blob/master/docs/dev/serialization.md). Without this support, `QasmUGate` cannot be properly serialized and deserialized, which causes issue quantumlib#4728. The test of serialization ability is done through the .repr and .json files under json_test_data folder. These files are also added for `QasmUGate`. close quantumlib#4728
This PR provides the serialization support for the `QasmUGate` class following [serialization.md](https://github.com/quantumlib/Cirq/blob/master/docs/dev/serialization.md). Without this support, `QasmUGate` cannot be properly serialized and deserialized, which causes issue quantumlib#4728. The test of serialization ability is done through the .repr and .json files under json_test_data folder. These files are also added for `QasmUGate`. close quantumlib#4728
This PR provides the serialization support for the `QasmUGate` class following [serialization.md](https://github.com/quantumlib/Cirq/blob/master/docs/dev/serialization.md). Without this support, `QasmUGate` cannot be properly serialized and deserialized, which causes issue quantumlib#4728. The test of serialization ability is done through the .repr and .json files under json_test_data folder. These files are also added for `QasmUGate`. close quantumlib#4728
This PR provides the serialization support for the
QasmUGateclass following serialization.md. Without this support,QasmUGatecannot be properly serialized and deserialized, which causes issue #4728.The test of serialization ability is done through the .repr and .json files under json_test_data folder. These files are also added for
QasmUGate.close #4728