Add classes to aid in providing simulated versions of devices #4747

dstrain115 · 2021-12-13T18:53:32Z

Add a validator that checks (some of) the common errors occuring
when sending circuits to quantum engine. This likely needs more
checks, but these can be added over time to match engine behavior.
Adds convenience functions to create SimulatedLocalEngine instances
from a device or from a device specification proto.
Adds proto device specifications for example Sycamore devices that
can be loaded without API access.

- Add a validator that checks (some of) the common errors occuring when sending circuits to quantum engine. This likely needs more checks, but these can be added over time to match engine behavior. - Adds convenience functions to create SimulatedLocalEngine instances from a device or from a device specification proto. - Adds proto device specifications for example Sycamore devices that can be loaded without API access.

mpharrigan · 2021-12-15T22:58:29Z

cirq-google/cirq_google/engine/engine_validator.py

+    max_repetitions: int = MAX_TOTAL_REPETITIONS,
+    max_duration_ns: int = 55000,
+) -> VALIDATOR_TYPE:
+    """Creates a Callanle gate set validator with a set message size."""


mpharrigan · 2021-12-15T22:59:37Z

cirq-google/cirq_google/engine/engine_validator.py

+    max_duration_ns: int = 55000,
+) -> VALIDATOR_TYPE:
+    """Creates a Callanle gate set validator with a set message size."""
+    return lambda c, s, r: validate_for_engine(


might want to double check the style guide, but I think the preferred style is to use an inline function definition rather than a variable here

def create_validator(...): def _validator(c, s, r): return return _validator

Yes, this looks and reads a lot better. Changed.

mpharrigan · 2021-12-15T23:00:20Z

cirq-google/cirq_google/engine/engine_validator.py

+    gate_set: Serializer,
+    max_size: int = MAX_MESSAGE_SIZE,
+) -> None:
+    """Validate that the message size is below the maximum size limit."""


document args here and other public functions

mpharrigan · 2021-12-15T23:02:13Z

cirq-google/cirq_google/engine/virtual_engine_factory.py

+    return create_noiseless_virtual_engine_from_proto(processor_ids, specifications, gate_sets)
+
+
+def create_noiseless_virtual_engine_from_latest_templates():


return type annotation here and elsewhere

dstrain115

Thanks for the review!

dstrain115 · 2021-12-16T13:52:03Z

cirq-google/cirq_google/engine/engine_validator.py

+    max_repetitions: int = MAX_TOTAL_REPETITIONS,
+    max_duration_ns: int = 55000,
+) -> VALIDATOR_TYPE:
+    """Creates a Callanle gate set validator with a set message size."""


dstrain115 · 2021-12-16T13:53:49Z

cirq-google/cirq_google/engine/engine_validator.py

+    max_duration_ns: int = 55000,
+) -> VALIDATOR_TYPE:
+    """Creates a Callanle gate set validator with a set message size."""
+    return lambda c, s, r: validate_for_engine(


Yes, this looks and reads a lot better. Changed.

dstrain115 · 2021-12-16T13:55:34Z

cirq-google/cirq_google/engine/virtual_engine_factory.py

+    return create_noiseless_virtual_engine_from_proto(processor_ids, specifications, gate_sets)
+
+
+def create_noiseless_virtual_engine_from_latest_templates():


dstrain115 · 2021-12-16T14:44:41Z

cirq-google/cirq_google/engine/engine_validator.py

+    gate_set: Serializer,
+    max_size: int = MAX_MESSAGE_SIZE,
+) -> None:
+    """Validate that the message size is below the maximum size limit."""


mpharrigan

some questionable unused arguments

mpharrigan · 2021-12-20T18:42:55Z

cirq-google/cirq_google/engine/engine_validator.py

+            raise RuntimeError('Code must measure at least one qubit.')
+
+
+def validate_gate_set(


cc @tanujkhattar @MichaelBroughton will this function be replaced once devices api and gatesets have fully landed?

It may need to be modified, but I don't think it will go away. We will still need to validate that the circuit has the correct gates.

mpharrigan · 2021-12-20T18:43:41Z

cirq-google/cirq_google/engine/engine_validator.py

+    Args:
+        max_size:  proto size limit to check against.
+
+    Returns: Callable to use in validation with the max_size already set.


max_size isn't used here. unless I'm missing something?

Oops, I forgot to add it to the generator function, even though that was the whole point. Also added a test to verify.

mpharrigan · 2021-12-20T18:44:36Z

cirq-google/cirq_google/engine/engine_validator.py

+    repetitions: Union[int, List[int]],
+    max_moments: int = MAX_MOMENTS,
+    max_repetitions: int = MAX_TOTAL_REPETITIONS,
+    max_duration_ns: int = 55000,


max_duration_ns unused?

Removed.
This was for testing the max duration of the circuit, but I need to go back and modify the way the durations are stored first. I'll add it back in a follow-up PR.

mpharrigan · 2021-12-20T18:48:14Z

cirq-google/cirq_google/engine/engine_validator.py

+    max_repetitions: int = MAX_TOTAL_REPETITIONS,
+    max_duration_ns: int = 55000,
+) -> VALIDATOR_TYPE:
+    """Creates a Callanle gate set validator with a set message size.


callanle -> callable

this is a matter of style, but I would find it enormously helpful if these factory functions gave some hint at where you could pass the result to:

"""Creates a validator...

This can be a useful helper for generating validators for cg.ValidatingSampler's validator argument
"""

Good idea. Done. Let me know if the additional paragraph is still not clear.

…Cirq-1 into add_engine_validator

…mlib#4747) Add classes to aid in providing simulated versions of devices - Add a validator that checks (some of) the common errors occurring when sending circuits to quantum engine. This likely needs more checks, but these can be added over time to match engine behavior. - Adds convenience functions to create SimulatedLocalEngine instances from a device or from a device specification proto. - Adds proto device specifications for example Sycamore devices that can be loaded without API access.

dstrain115 requested review from cduck, vtomole, wcourtney and a team as code owners December 13, 2021 18:53

dstrain115 requested a review from viathor December 13, 2021 18:53

CirqBot added the size: XL lines changed >1000 label Dec 13, 2021

MichaelBroughton self-assigned this Dec 13, 2021

dstrain115 added 3 commits December 13, 2021 13:07

Merge branch 'master' into add_engine_validator

4fddb79

Fix typing.

3fbafd4

Add ability to have multiple processors and create a default factory.

06d58f2

mpharrigan reviewed Dec 15, 2021

View reviewed changes

Address review comments.

450112f

dstrain115 commented Dec 16, 2021

View reviewed changes

dstrain115 requested a review from mpharrigan December 20, 2021 13:33

mpharrigan approved these changes Dec 20, 2021

View reviewed changes

dstrain115 added 2 commits December 23, 2021 07:08

Address mpharrigan review commnents.

86f4fea

fix typo

8027f54

mpharrigan approved these changes Dec 23, 2021

View reviewed changes

dstrain115 added 3 commits December 27, 2021 05:12

Merge branch 'master' into add_engine_validator

500272a

Merge branch 'master' into add_engine_validator

a645982

Merge branch 'add_engine_validator' of https://github.com/dstrain115/…

0746306

…Cirq-1 into add_engine_validator

dstrain115 merged commit 58f6a6f into quantumlib:master Dec 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add classes to aid in providing simulated versions of devices #4747

Add classes to aid in providing simulated versions of devices #4747

dstrain115 commented Dec 13, 2021

mpharrigan Dec 15, 2021

dstrain115 Dec 16, 2021

mpharrigan Dec 15, 2021

dstrain115 Dec 16, 2021

mpharrigan Dec 15, 2021

dstrain115 Dec 16, 2021

mpharrigan Dec 15, 2021

dstrain115 Dec 16, 2021

dstrain115 left a comment

dstrain115 Dec 16, 2021

dstrain115 Dec 16, 2021

dstrain115 Dec 16, 2021

dstrain115 Dec 16, 2021

mpharrigan left a comment

mpharrigan Dec 20, 2021

dstrain115 Dec 23, 2021

mpharrigan Dec 20, 2021

dstrain115 Dec 23, 2021

mpharrigan Dec 20, 2021

dstrain115 Dec 23, 2021

mpharrigan Dec 20, 2021

mpharrigan Dec 20, 2021

dstrain115 Dec 23, 2021

		return create_noiseless_virtual_engine_from_proto(processor_ids, specifications, gate_sets)


		def create_noiseless_virtual_engine_from_latest_templates():

		raise RuntimeError('Code must measure at least one qubit.')


		def validate_gate_set(

Add classes to aid in providing simulated versions of devices #4747

Add classes to aid in providing simulated versions of devices #4747

Conversation

dstrain115 commented Dec 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dstrain115 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpharrigan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment