Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FrozenCircuit incg.Engine #4731

Merged

Conversation

tanujkhattar
Copy link
Collaborator

@tanujkhattar tanujkhattar commented Dec 7, 2021

Fixes #4730

@tanujkhattar tanujkhattar requested review from cduck, vtomole, wcourtney and a team as code owners December 7, 2021 14:36
@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 7, 2021
@maffoo
Copy link
Contributor

maffoo commented Dec 7, 2021

Can we do the long-term and update cg.Engine instead?

@mpharrigan
Copy link
Collaborator

yeah I would think there would be very little changes required to engine. I don't think it's using any of the mutability features of cirq.Circuit

@tanujkhattar
Copy link
Collaborator Author

@maffoo @mpharrigan Did the long term fix and updated cg.Engine and a few other files to add support for FrozenCircuit everywhere.

@tanujkhattar tanujkhattar changed the title Support FrozenCircuit in QuantumEngineSampler.run_sweep Support FrozenCircuit incg.Engine Dec 7, 2021
@tanujkhattar tanujkhattar merged commit 5ee7ff6 into quantumlib:master Dec 7, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Support FrozenCircuit in QuantumEngineSampler.run_sweep

* Support FrozenCircuit cg.Engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cirqflow] Quantum Executable workflow broken because Engine. _serialize_program doesn't support FrozenCircuit
4 participants