-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime] QubitPlacer #4678
Closed
Closed
[runtime] QubitPlacer #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
force-pushed
the
2021-11-qubit-placement
branch
from
November 23, 2021 00:03
fcb03ac
to
a2b8597
Compare
mpharrigan
force-pushed
the
2021-11-qubit-placement
branch
from
December 2, 2021 00:25
a2b8597
to
c72ad32
Compare
CirqBot
pushed a commit
that referenced
this pull request
Dec 2, 2021
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Splitting up quantumlib#4678 - The interface: `QubitPlacer` - The fallback: `NaiveQubitPlacer` - runtime hooks some hacks around quantumlib#4699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/google/placement
area/workflow
cla: yes
Makes googlebot stop complaining.
size: L
250< lines changed <1000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a
QubitPlacer
abstract interface, some example concrete implementations, hooks intocg.workflow.execute
to plumb in the new interface, and shims highlighting some of the blockers.Including qubit placement as part of the quantum runtime is important for our benchmarking / data science requirements.
In order of increasing sophistication, I want to support the following strategies for qubit placement
NaiveQubitPlacer
HardcodedQubitPlacer
RandomDevicePlacer
Please take a look at this sketch of the interface and the example concrete implementations given the above list. Please raise any structural or naming concerns now. I'll split up into a PR for the interface and runtime
execute
hooks, then one for each strategy.You can see that there are several device-related blockers in this
SharedRuntimeInformation
.__eq__
equality testing.cc @MichaelBroughton @dstrain115 @tanujkhattar @dabacon