-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for documentation #4635
Fixes for documentation #4635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OSError: If the environment variable GOOGLE_CLOUD_PROJECT is not set. This is actually | ||
an `EnvironmentError`, which by definition is an `OsError`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically correct, the best kind of correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint yells if you call it an EnvironmentError
, so this is the annoying workaround.
First page of searching for quantumlib#3388 TODOs. Non-trivial changes: * AQT was making extra isinstance checks on operations to be of a gate type.
First page of searching for quantumlib#3388 TODOs. Non-trivial changes: * AQT was making extra isinstance checks on operations to be of a gate type.
First page of searching for #3388 TODOs.
Non-trivial changes: