Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for documentation #4635

Merged
merged 8 commits into from
Nov 9, 2021
Merged

Fixes for documentation #4635

merged 8 commits into from
Nov 9, 2021

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Nov 8, 2021

First page of searching for #3388 TODOs.

Non-trivial changes:

  • AQT was making extra isinstance checks on operations to be of a gate type.

@dabacon dabacon requested a review from mpharrigan November 8, 2021 00:57
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Nov 8, 2021
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 8, 2021
@MichaelBroughton MichaelBroughton self-assigned this Nov 8, 2021
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cirq-aqt/cirq_aqt/aqt_device.py Outdated Show resolved Hide resolved
cirq-google/cirq_google/api/v2/results.py Outdated Show resolved Hide resolved
Comment on lines +814 to +815
OSError: If the environment variable GOOGLE_CLOUD_PROJECT is not set. This is actually
an `EnvironmentError`, which by definition is an `OsError`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically correct, the best kind of correct.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint yells if you call it an EnvironmentError, so this is the annoying workaround.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 9, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 9, 2021
@CirqBot CirqBot merged commit 3b2b2d8 into quantumlib:master Nov 9, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 9, 2021
@dabacon dabacon deleted the docfixes branch April 16, 2022 15:42
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
First page of searching for quantumlib#3388 TODOs.

Non-trivial changes:
* AQT was making extra isinstance checks on operations to be of a gate type.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
First page of searching for quantumlib#3388 TODOs.

Non-trivial changes:
* AQT was making extra isinstance checks on operations to be of a gate type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants