-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named topologies: support manual placement #4628
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
): | ||
"""Draw a visualization of placements from small_graph onto big_graph using Matplotlib. | ||
|
||
The entire `big_graph` will be drawn with default blue colored nodes. `small_graph` nodes | ||
and edges will be highlighted with a red color. | ||
|
||
Args: | ||
big_graph: A larger graph to draw with blue colored nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: parent graph ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be a breaking change and less clear of a name, imo
- Helper method to get mappings to gridqubits - Document how to manually place TiltedSquareLattice and LineTopology graphs onto a sample device - Let `draw_placements` accept `tilted` boolean like the other draw methods - added some missing docstrings and type annotations ![image](https://user-images.githubusercontent.com/4967059/140413234-d21fe08b-ec9e-4b5c-81d9-3600b4884799.png)
- Helper method to get mappings to gridqubits - Document how to manually place TiltedSquareLattice and LineTopology graphs onto a sample device - Let `draw_placements` accept `tilted` boolean like the other draw methods - added some missing docstrings and type annotations ![image](https://user-images.githubusercontent.com/4967059/140413234-d21fe08b-ec9e-4b5c-81d9-3600b4884799.png)
draw_placements
accepttilted
boolean like the other draw methods